Split translations between EW and shared components#31441
Merged
Conversation
Uses update module API with global TranslationKey type that can be overridden. WIP.
NB. there are lots of removed strings for a few languages where we seem to have hit a localazy bug or something where the key/value for plurals got switched, making the translations invalid. They've been missing for a while so I'm removing them rather than trying to restore them,
for the built app
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses updated module API with global TranslationKey type that can be overridden.
This does a bunch of things because it turned out to be easier to do them all together:
TranslationKeya global type and override it in each project to be the keys of that project, based off each project's new en_EN.jsonWhat it does not do (that can be done later):
Note that this changes the "i18n Check" workflow to split it into two so the expected checks will need changing, so this will stay pending on this PR until we update it. The two new i18n check jobs are expected fails because we are deliberately changing translated language files.
To do after merge:
localazy upload existing(with appropriate creds) to upload the shared-component non-source translations (this could also be just before merge)Checklist
public/exportedsymbols have accurate TSDoc documentation.